-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change default deploytype to avoid defaulting to invalid type #207
Merged
davidgamero
merged 14 commits into
Azure:main
from
davidgamero:davidgamero/default-deploytype-bugfix
May 2, 2023
Merged
change default deploytype to avoid defaulting to invalid type #207
davidgamero
merged 14 commits into
Azure:main
from
davidgamero:davidgamero/default-deploytype-bugfix
May 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OliverMKing
approved these changes
Apr 19, 2023
bfoley13
approved these changes
Apr 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for the bug fix. Lets also think about adding the validation for other defaults where it makes sense
OliverMKing
approved these changes
Apr 21, 2023
OliverMKing
approved these changes
Apr 21, 2023
bfoley13
approved these changes
May 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice updates for handling the defaults
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The default for the deploytype flag is currently set to
.
, which isn't a valid deployment type, and causes a nil pointer error.In order to catch this in the future, a new smoke test action was added that uses the default for every option.
This smoke test fails with invalid defaults like the one this PR fixes, and we should consider adding one for other commands once we have the ability to extract sane defaults for all of the flags on other commands.
Since the APPNAME variable didn't have a default, I added one to the draft.yaml allowing this smoke test to execute, and providing a basic default for testing.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Validated with new error return on deployment type lookup
Added new smoke test for create command
Checklist: