Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration test for multiple OS #213

Merged
merged 12 commits into from
Jun 7, 2023

Conversation

hsubramanianaks
Copy link
Contributor

@hsubramanianaks hsubramanianaks commented May 22, 2023

Description

Integration tests for multiple OS - including windows, macos and fixes #211

Fixes # (issue)
Feature # (details)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s).

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Member

@Tatsinnit Tatsinnit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☕️🥷

Copy link
Collaborator

@davidgamero davidgamero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, great improvement!

@Tatsinnit Tatsinnit added the enhancement New feature or request label Jun 6, 2023
@Tatsinnit
Copy link
Member

Tatsinnit commented Jun 6, 2023

Oh, ☕️💡 The merge is blocked because commits require signing https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification

cc: @hsubramanianaks thanks heaps and fyi - @davidgamero thanks.

@hsubramanianaks hsubramanianaks force-pushed the enhance-integration-test branch 2 times, most recently from c296959 to c78530e Compare June 7, 2023 15:18
@hsubramanianaks
Copy link
Contributor Author

Oh, ☕️💡 The merge is blocked because commits require signing https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification

cc: @hsubramanianaks thanks heaps and fyi - @davidgamero thanks.

Done updated to signed commits :)

@hsubramanianaks hsubramanianaks merged commit 4fc212e into Azure:main Jun 7, 2023
@hsubramanianaks hsubramanianaks deleted the enhance-integration-test branch June 7, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not install the latest version of Azure Draft
3 participants