Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changes for python file entry point detection #217

Merged
merged 11 commits into from
Jul 7, 2023
Merged

changes for python file entry point detection #217

merged 11 commits into from
Jul 7, 2023

Conversation

bosesuneha
Copy link
Member

@bosesuneha bosesuneha commented Jun 17, 2023 •
edited
Loading

Description

Added code to extract the python entry point file and set it in the generated Dockerfile.

Fixes # (issue)
Feature # (details)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s).

  • Unit Tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Tatsinnit Tatsinnit requested a review from davidgamero June 19, 2023 18:12
@Tatsinnit Tatsinnit added the enhancement New feature or request label Jun 19, 2023
OliverMKing
OliverMKing approved these changes Jun 19, 2023
View reviewed changes
Copy link
Contributor

@OliverMKing OliverMKing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Good additions!

davidgamero
davidgamero requested changes Jun 29, 2023
View reviewed changes
cmd/create_test.go Outdated Show resolved Hide resolved
pkg/languages/defaults/python.go Show resolved Hide resolved
pkg/languages/defaults/python_test.go Outdated Show resolved Hide resolved
template/dockerfiles/python/Dockerfile Show resolved Hide resolved
davidgamero
davidgamero reviewed Jul 7, 2023
View reviewed changes
Copy link
Collaborator

@davidgamero davidgamero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@bosesuneha bosesuneha merged commit 5602b8a into Azure:main Jul 7, 2023
@bosesuneha bosesuneha deleted the python-entrypoint-detection branch July 19, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OliverMKing OliverMKing OliverMKing approved these changes

@davidgamero davidgamero davidgamero approved these changes

Assignees

@bosesuneha bosesuneha

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bosesuneha @davidgamero @OliverMKing @Tatsinnit