-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Draft Validate functionality into main #281
Conversation
note: rebased #279 here onto main to handle divergent branches from patching go module versions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Left a few comments but nothing blocking. Good work!
In the future it seems straightforward to make this support json and helm files too which would be great!
One concern I have is how the scheme is used. I can't find how it's used but if it's used for reading customer's manifests it could fail if they use a CRD. If it's just used for loading our policy definitions then there's no problem there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm great work!
8a7806e
to
6a5a4af
Compare
6a5a4af
to
a974ef7
Compare
cec5547
to
48b6b18
Compare
48b6b18
to
92b2c83
Compare
Description
Host of new features to enable the
draft validate
command into the main branch.Fixes # (issue)
Feature # (details)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s).
Checklist: