Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Draft Validate functionality into main #281

Merged
merged 1 commit into from
May 20, 2024

Conversation

tbarnes94
Copy link
Member

@tbarnes94 tbarnes94 commented May 20, 2024

Description

Host of new features to enable the draft validate command into the main branch.

Fixes # (issue)
Feature # (details)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s).

  • Unit test suite for cmd/validate and pkg/safeguards

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@tbarnes94 tbarnes94 enabled auto-merge (squash) May 20, 2024 16:58
@davidgamero
Copy link
Collaborator

note: rebased #279 here onto main to handle divergent branches from patching go module versions

cmd/validate.go Outdated Show resolved Hide resolved
cmd/validate.go Outdated Show resolved Hide resolved
go.mod Show resolved Hide resolved
Copy link
Contributor

@OliverMKing OliverMKing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left a few comments but nothing blocking. Good work!

In the future it seems straightforward to make this support json and helm files too which would be great!

One concern I have is how the scheme is used. I can't find how it's used but if it's used for reading customer's manifests it could fail if they use a CRD. If it's just used for loading our policy definitions then there's no problem there

Copy link
Collaborator

@davidgamero davidgamero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm great work!

@tbarnes94 tbarnes94 requested a review from NickKeller May 20, 2024 21:39
@tbarnes94 tbarnes94 force-pushed the validate-command branch 2 times, most recently from 8a7806e to 6a5a4af Compare May 20, 2024 22:30
@tbarnes94 tbarnes94 force-pushed the validate-command branch 2 times, most recently from cec5547 to 48b6b18 Compare May 20, 2024 22:46
@tbarnes94 tbarnes94 merged commit 315e47b into Azure:main May 20, 2024
149 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants