Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverting the graphsdk to azcli #295

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

Vidya2606
Copy link
Contributor

@Vidya2606 Vidya2606 commented May 30, 2024

Description

I'm reverting from graphsdk to azcli because few of the functions for which I made the changes would require registration to Graph App which means the user had to do a device code login in the web browser which seemed to be a bad user experience, so we decided to keep the functions as is.

getAppObjectId: #260
assignSpRole: #272

Fixes # (issue)
Feature # (details)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s).

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Member

@Tatsinnit Tatsinnit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☕️ thanks heaps Vidya!! since it’s just revert seems ok to me at revert level 😊 but I have asked a question and might repeat here for archive, it will be worth to add context for this revert as to why we are going back to exec.command?

Thank you so much as always for kind ping!! I will lil bird fyi @davidgamero for wiz look and eyes.

Copy link
Member

@bfoley13 bfoley13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good for me, @davidgamero for final approval

Copy link
Collaborator

@davidgamero davidgamero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes looks good to me, validated manually with a full deployment to an aks cluster.

@davidgamero davidgamero enabled auto-merge (squash) June 4, 2024 20:57
@davidgamero davidgamero merged commit 021ceaa into Azure:main Jun 4, 2024
149 checks passed
@Vidya2606 Vidya2606 deleted the rebasing_msgraphClient branch June 5, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants