Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup for kustomize/helm feature #357

Merged
merged 3 commits into from
Aug 2, 2024
Merged

Conversation

manasachi
Copy link
Contributor

@manasachi manasachi commented Aug 1, 2024

Description

Removing unused functions and constants relevant to helm/kustomize feature, adding comments

Fixes # (issue)
Feature # (details)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Refactor

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s).

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@manasachi manasachi changed the base branch from main to staging-safeguards August 1, 2024 13:23
@manasachi manasachi requested a review from NickKeller August 1, 2024 16:54
@manasachi manasachi merged commit 0bfcf23 into staging-safeguards Aug 2, 2024
2 checks passed
@manasachi manasachi deleted the mchinta/cleanup branch August 2, 2024 15:05
This was referenced Aug 12, 2024
sallasindhuja pushed a commit that referenced this pull request Aug 22, 2024
manasachi added a commit that referenced this pull request Oct 7, 2024
manasachi added a commit that referenced this pull request Oct 7, 2024
Signed-off-by: Manasa Chinta <manasachinta7@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants