Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate createRole assignment to Az SDK #388

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

Vidya2606
Copy link
Contributor

Description

Migrating create role assignment from Az CLI to Az SDK

Fixes # (issue)
Feature # (details)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s).

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Tatsinnit Tatsinnit added the enhancement New feature or request label Sep 26, 2024
@Tatsinnit Tatsinnit requested review from davidgamero, bfoley13 and a team September 26, 2024 20:54
Copy link
Contributor

@hsubramanianaks hsubramanianaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just a minor suggestion. Thank you @Vidya2606

@davidgamero
Copy link
Collaborator

Running a credential test on a local build of this branch, then I'll approve

pkg/providers/az-client.go Outdated Show resolved Hide resolved
@davidgamero
Copy link
Collaborator

lgtm. I was able to run the build without encountering the PrincipalNotFound error from before

@Vidya2606 Vidya2606 force-pushed the migrateProviderPackage branch 4 times, most recently from 28f97b4 to a02cabd Compare October 23, 2024 21:52
@Vidya2606 Vidya2606 force-pushed the migrateProviderPackage branch from a02cabd to 135afd0 Compare October 23, 2024 21:55
@Vidya2606 Vidya2606 force-pushed the migrateProviderPackage branch from f9bc2d2 to 2b42fb2 Compare October 23, 2024 23:31
Copy link
Collaborator

@davidgamero davidgamero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@davidgamero davidgamero merged commit 2307636 into Azure:main Oct 24, 2024
149 checks passed
@bfoley13 bfoley13 mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants