Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate workflows to template handler #412

Merged
merged 16 commits into from
Oct 30, 2024

Conversation

davidgamero
Copy link
Collaborator

@davidgamero davidgamero commented Oct 22, 2024

Description

Migrate the workflow generation to use handler templates

Fixes # (issue)
Feature # (details)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Refactor

How Has This Been Tested?

Provide instructions so we can reproduce, and list any relevant details for your test configuration. Please mention if this is a breaking change which will impact consuming tool(s).

  • Unit Test:
  • E2E Test:
  • Other Test:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

cmd/generate-workflow.go Outdated Show resolved Hide resolved
@davidgamero davidgamero enabled auto-merge (squash) October 29, 2024 18:13
@davidgamero davidgamero merged commit 67bd519 into main Oct 30, 2024
149 checks passed
@davidgamero davidgamero deleted the davidgamero/generation-workflows branch October 30, 2024 16:49
@bfoley13 bfoley13 mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants