New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add selectors and azclient cleanup #425

Merged

bfoley13 merged 1 commit into main from davidgamero/setup-gh-selectors

Nov 20, 2024

Collaborator

davidgamero commented Nov 12, 2024 •

edited

Loading

Description

Changes in setup-gh command:

Centralize Credentials management in AzClient
Abstract AzClient out of the SetupCommand
Provide a default app name of "-workflow"
Use the Select Prompt for Tenant and ResourceGroup
Autofill gh repo name default value using gh cli
Allow overriding validators (gh repo/az cli validity checks)
Update Select Searcher to allow matching out-of-order terms (space delimited, case-insensitive)

davidgamero marked this pull request as ready for review

November 14, 2024 22:46

Tatsinnit assigned davidgamero

Tatsinnit added the enhancement label

Tatsinnit requested review from tbarnes94, erinborders, Vidya2606, bfoley13, Tatsinnit and a team

November 15, 2024 00:32

Tatsinnit approved these changes

View reviewed changes

Member

Tatsinnit left a comment

❤️ Looks good to me, thank you so much for this, I've added folks who have touched this in past just as eyeball and I am sure you have taken care of the rest!! Thank you for the ping as well.

cmd/setup-gh.go Outdated Show resolved Hide resolved

cmd/setup-gh.go Outdated Show resolved Hide resolved

pkg/providers/az-client.go Outdated Show resolved Hide resolved

pkg/providers/az-client.go Outdated Show resolved Hide resolved

pkg/providers/az-client.go Outdated Show resolved Hide resolved

bfoley13 reviewed

View reviewed changes

cmd/setup-gh.go Outdated Show resolved Hide resolved

bfoley13 reviewed

View reviewed changes

cmd/setup-gh.go Outdated Show resolved Hide resolved

bfoley13 reviewed

View reviewed changes

cmd/setup-gh.go Outdated Show resolved Hide resolved

bfoley13 reviewed

View reviewed changes

cmd/setup-gh.go Outdated Show resolved Hide resolved

bfoley13 reviewed

View reviewed changes

pkg/providers/azure.go Outdated Show resolved Hide resolved

bfoley13 reviewed

View reviewed changes

cmd/setup-gh.go Outdated Show resolved Hide resolved

Tatsinnit approved these changes

View reviewed changes

Member

Tatsinnit left a comment

☕️❤️

bfoley13 reviewed

View reviewed changes

test/integration/swift/manifest.yaml Outdated Show resolved Hide resolved


          setup gh selectors

ffb3838

davidgamero force-pushed the davidgamero/setup-gh-selectors branch from b994d34 to ffb3838 Compare

November 19, 2024 20:21

bfoley13 approved these changes

View reviewed changes

Member

bfoley13 left a comment

will be nice to have this in!

bfoley13 merged commit 04c6cba into main

149 checks passed

bfoley13 deleted the davidgamero/setup-gh-selectors branch

November 20, 2024 14:22

audrastump pushed a commit to audrastump/draft that referenced this pull request


          add selectors and azclient cleanup (Azure#425)

4090b7d

audrastump pushed a commit to audrastump/draft that referenced this pull request


          add selectors and azclient cleanup (Azure#425)

46256ff

audrastump pushed a commit to audrastump/draft that referenced this pull request


          add selectors and azclient cleanup (Azure#425)

5c11f61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Tatsinnit Tatsinnit approved these changes

bfoley13 bfoley13 approved these changes

tbarnes94 Awaiting requested review from tbarnes94

erinborders Awaiting requested review from erinborders

Vidya2606 Awaiting requested review from Vidya2606

Labels