Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating templates and moving tests #428

Merged
merged 11 commits into from
Nov 21, 2024
Merged

Updating templates and moving tests #428

merged 11 commits into from
Nov 21, 2024

Conversation

bfoley13
Copy link
Member

@bfoley13 bfoley13 commented Nov 18, 2024

Description

Changes include:

  • updating deployment templates with probe type and adding startup probe
  • added imagePullPolicy to deployment templates
  • added workload identity handling to deployments
  • added an optional secret ref to deployments
  • adding allowedValues on DraftConfig BuilderVar
  • added ConditionValue to BuilderVarConditionalReference
  • Moving tests to individual files

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Refactor

How Has This Been Tested?

Provide instructions so we can reproduce, and list any relevant details for your test configuration. Please mention if this is a breaking change which will impact consuming tool(s).

  • Unit Test:
  • E2E Test:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@bfoley13 bfoley13 marked this pull request as ready for review November 18, 2024 20:13
@bfoley13 bfoley13 requested a review from davidgamero November 19, 2024 17:00
@bfoley13 bfoley13 enabled auto-merge (squash) November 20, 2024 23:26
Copy link
Collaborator

@davidgamero davidgamero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bfoley13 bfoley13 merged commit e896b21 into main Nov 21, 2024
149 checks passed
@bfoley13 bfoley13 deleted the brfole/template-changes branch November 21, 2024 17:12
@bfoley13 bfoley13 mentioned this pull request Dec 4, 2024
audrastump pushed a commit to audrastump/draft that referenced this pull request Dec 13, 2024
audrastump pushed a commit to audrastump/draft that referenced this pull request Dec 16, 2024
audrastump pushed a commit to audrastump/draft that referenced this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants