Support FullyQualifiedMethodNames in CreateRetryableClient and log en…

…hancements (#54)

* some logging improvements

* support for FullyQualifiedMethodNames in CreateRetryableClient

Framework/OrchestrationContext.cs

@@ -83,12 +83,33 @@ public virtual T CreateClient<T>(bool useFullyQualifiedMethodNames) where T : cl
         /// <returns>Dynamic proxy that can be used to schedule the remote tasks</returns>
         public virtual T CreateRetryableClient<T>(RetryOptions retryOptions) where T : class
         {
-            if (!typeof (T).IsInterface)
+            return this.CreateRetryableClient<T>(retryOptions, false);
+        }
+
+        /// <summary>
+        ///     Creates a proxy client with built-in retry logic.
+        /// </summary>
+        /// <typeparam name="T">
+        ///     Task version of the client interface.
+        ///     This is similar to the actual interface implemented by the client but with the
+        ///     return types always of the form Task&lt;TOriginal&gt;
+        ///     where TOriginal was the return
+        ///     type for the same method in the original interface
+        /// </typeparam>
+        /// <param name="retryOptions">Retry policies</param>
+        /// <param name="useFullyQualifiedMethodNames">
+        ///     If true, the method name translation from the interface contains
+        ///     the interface name, if false then only the method name is used
+        /// </param>
+        /// <returns>Dynamic proxy that can be used to schedule the remote tasks</returns>
+        public virtual T CreateRetryableClient<T>(RetryOptions retryOptions, bool useFullyQualifiedMethodNames) where T : class
+        {
+            if (!typeof(T).IsInterface)
             {
                 throw new InvalidOperationException("Pass in an interface.");
             }
 
-            var scheduleProxy = new ScheduleProxy(this, typeof (T));
+            var scheduleProxy = new ScheduleProxy(this, typeof(T), useFullyQualifiedMethodNames);
             var retryProxy = new RetryProxy<T>(this, retryOptions, scheduleProxy.ActLike<T>());
             return retryProxy.ActLike<T>();
         }

Framework/ReflectionBasedTaskActivity.cs

@@ -77,7 +77,7 @@ public override async Task<string> RunAsync(TaskContext context, string input)
             if (methodParameters.Length < parameterCount)
             {
                 throw new TaskFailureException(
-                    "TaskActivity implementation cannot be invoked due to more than expected input parameters.  Signature mismatch.");
+                    this.FormatExceptionMessage("TaskActivity implementation cannot be invoked due to more than expected input parameters.  Signature mismatch."));
             }
             var inputParameters = new object[methodParameters.Length];
             for (int i = 0; i < methodParameters.Length; i++)
@@ -136,25 +136,30 @@ public override async Task<string> RunAsync(TaskContext context, string input)
             {
                 Exception realException = e.InnerException ?? e;
                 string details = Utils.SerializeCause(realException, DataConverter);
-                throw new TaskFailureException(realException.Message, details);
+                throw new TaskFailureException(this.FormatExceptionMessage(realException.Message), details);
             }
             catch (Exception e) when (!Utils.IsFatal(e))
             {
                 string details = Utils.SerializeCause(e, DataConverter);
-                throw new TaskFailureException(e.Message, e, details);
+                throw new TaskFailureException(this.FormatExceptionMessage(e.Message), e, details);
             }
 
             return serializedReturn;
         }
 
         /// <summary>
-        /// Invokes the target method on the actiivity object with supplied paarameters
+        /// Invokes the target method on the actiivity object with supplied parameters
         /// </summary>
         /// <param name="inputParameters"></param>
         /// <returns></returns>
         public virtual object InvokeActivity(object[] inputParameters)
         {
             return MethodInfo.Invoke(activityObject, inputParameters);
         }
+
+        string FormatExceptionMessage(string message)
+        {
+            return $"{message}: @{this.MethodInfo.ReflectedType?.FullName}.{this.MethodInfo.Name}";
+        }
     }
 }

Framework/TaskActivity.cs

@@ -144,7 +144,7 @@ public override async Task<string> RunAsync(TaskContext context, string input)
             catch (Exception e) when (!Utils.IsFatal(e))
             {
                 string details = Utils.SerializeCause(e, DataConverter);
-                throw new TaskFailureException(e.Message, details);
+                throw new TaskFailureException(e.Message, e, details);
             }
 
             string serializedResult = DataConverter.Serialize(result);

Framework/TaskOrchestrationDispatcher.cs

@@ -357,7 +357,8 @@ static TaskMessage ProcessWorkflowCompletedTaskDecision(
 
             runtimeState.AddEvent(executionCompletedEvent);
 
-            TraceHelper.TraceInstance(TraceEventType.Information, runtimeState.OrchestrationInstance,
+            TraceHelper.TraceInstance(runtimeState.OrchestrationStatus == OrchestrationStatus.Failed ? TraceEventType.Warning : TraceEventType.Information, 
+                runtimeState.OrchestrationInstance,
                 "Instance Id '{0}' completed in state {1} with result: {2}",
                 runtimeState.OrchestrationInstance, runtimeState.OrchestrationStatus, completeOrchestratorAction.Result);
             TraceHelper.TraceInstance(TraceEventType.Information, runtimeState.OrchestrationInstance,