Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Versioning support in durabletask(phase1) #1071

Merged
merged 4 commits into from
Apr 25, 2024

Conversation

skyao
Copy link
Contributor

@skyao skyao commented Apr 22, 2024

Code updates:

  • OrchestrationContext

    Add a new field called Version to indicate the version of the current orchestration instance. Version will be set when the orchestration instance is created.

  • TaskOrchestrationExecutor

    Get the instance version from version field on the ExecutionStartedEvent and save it to TaskOrchestrationContext.Version so that it can be used in the orchestration code.

… current orchestration instance

Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
…trationInstance so that it can be used in the orchestration code

Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
…ion on OrchestrationContext

Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
Copy link
Member

@cgillum cgillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me as a first step. @jviau do you have any objections to this change?

Copy link
Collaborator

@jviau jviau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Getting version was annoying before - I always had to extract it in the middleware and save it somewhere (typically a property on the orchestration)

@cgillum cgillum merged commit 68ec683 into Azure:main Apr 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants