Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Queue TTL to infinite #666

Merged
merged 4 commits into from
Feb 1, 2022
Merged

Updated Queue TTL to infinite #666

merged 4 commits into from
Feb 1, 2022

Conversation

amdeel
Copy link
Contributor

@amdeel amdeel commented Jan 19, 2022

Updated queue time to live to infinite to avoid messages from being deleted after 7 days resulting in stuck orchestrations.

resolves #660

@amdeel amdeel requested a review from cgillum January 19, 2022 20:16
Copy link
Member

@cgillum cgillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It'd be great if we can update the comment to make it clear what we're doing. Also, it would be good to test this in a Functions v1 environment (if you haven't already) since we use an even older storage SDK version there.

src/DurableTask.AzureStorage/Storage/Queue.cs Outdated Show resolved Hide resolved
@amdeel amdeel merged commit 6c1fda6 into main Feb 1, 2022
@amdeel amdeel deleted the ttlFix branch February 1, 2022 17:37
// Infinite time to live
TimeSpan? timeToLive = TimeSpan.FromSeconds(-1);
#if NET461
// When using net461 SDK version WindowsAzure.Storage 7.2.1 does not allow infinite time to live. Passing in null will default the time to live to 7 days.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would TimeSpan.MaxValue work in that case? It would be much better than the 7 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Message added to Azure Storage Control queue is created with TTL of 7 days by default
3 participants