Remove conn.mux #173
Merged
Remove conn.mux #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhendrixMSFT
requested review from
richardpark-msft and
RickWinter
as code owners
jhendrixMSFT
force-pushed
the
conn_mux
branch
2 times, most recently
from
c8b4c29
to
89d356a
Compare
jhendrixMSFT
commented
Jul 21, 2022
|
There's a failure in our websockets negotiation, I have a draft PR with my branch that merges in your changes: |
jhendrixMSFT
force-pushed
the
conn_mux
branch
from
d8c6e5e
to
30a8de2
Compare
jhendrixMSFT
force-pushed
the
conn_mux
branch
4 times, most recently
from
9975484
to
ada9e2b
Compare
jhendrixMSFT
force-pushed
the
conn_mux
branch
from
ada9e2b
to
101ebb6
Compare
|
Test |
|
Test bug, fix pending. |
jhendrixMSFT
force-pushed
the
conn_mux
branch
2 times, most recently
from
0e27105
to
f0007e0
Compare
jhendrixMSFT
force-pushed
the
conn_mux
branch
from
f0007e0
to
c2c1d89
Compare
|
Switching back to draft for now as I want to wait to merge this until after the API clean-up changes are in and released. |
jhendrixMSFT
force-pushed
the
conn_mux
branch
from
c2c1d89
to
17cf732
Compare
jhendrixMSFT
force-pushed
the
conn_mux
branch
from
17cf732
to
d5013f2
Compare
jhendrixMSFT
force-pushed
the
conn_mux
branch
from
14e0e7b
to
07fd837
Compare
richardpark-msft
approved these changes
Dec 13, 2022
There was a problem hiding this comment.
It's really looking good to me. It's in the heart of the AMQP stack though, so we should probably come up with some more extreme cases for testing as well since SB and EH don't necessarily push the boundaries too much in normal operation.
I also left some comments in spots where there might be perf bottlenecks that we could investigate as well.
conn.connReader() dispatches frames directly to sessions now. Added conn.NextSession() and conn.DeleteSession() for deterministic session management. Channel numbers are now recycled immediately which prompted a fix for TestSessionClose. Fixed various tests to handle close frame (the error was being swallowed before). Tests that utilize testconn were silently failing due to a bug in Conn.Read which has been fixed.
fixed propagation of RemoteErr on close
jhendrixMSFT
force-pushed
the
conn_mux
branch
from
23e4d07
to
e23e655
Compare
richardpark-msft
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
conn.connReader() dispatches frames directly to sessions now.
Added conn.NextSession() and conn.DeleteSession() for deterministic
session management.
Channel numbers are now recycled immediately which prompted a fix for
TestSessionClose.
Fixed various tests to handle close frame (the error was being swallowed
before).
Tests that utilize testconn were silently failing due to a bug in
Conn.Read which has been fixed.
Fixes #164