Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Environment: MicrosoftGraphEndpoints #585

Closed
miosmian opened this issue Dec 2, 2020 · 2 comments
Closed

Environment: MicrosoftGraphEndpoints #585

miosmian opened this issue Dec 2, 2020 · 2 comments

Comments

@miosmian
Copy link

miosmian commented Dec 2, 2020

Currently the Environment.GraphEndpoint corresponds to "https://graph.windows.net/", (other cloud endpoints follow this format) but the new microsoft graph unified api endpoint is not in this struct. Are there plans to add this? It would be,

Environment.GraphEndpoint = "https://graph.microsoft.com/", (public cloud)
Environment.GraphEndpoint = "https://graph.microsoft-ppe.com/", (ppe)
and others for Gov..etc clouds?
mbarnes added a commit to mbarnes/ARO-RP that referenced this issue Apr 11, 2022
@mbarnes
azureclient: Add MicrosoftGraphEndpoint to AROEnvironment
4d90a3b 
The Azure/go-autorest module does not define an endpoint for the
Microsoft Graph API [1] so define it ourselves for now.

[1] Azure/go-autorest#585
mbarnes added a commit to mbarnes/ARO-RP that referenced this issue Apr 15, 2022
@mbarnes
azureclient: Add MicrosoftGraphEndpoint to AROEnvironment
73f0922 
The Azure/go-autorest module does not define an endpoint for the
Microsoft Graph API [1] so define it ourselves for now.

[1] Azure/go-autorest#585
@jhendrixMSFT
Copy link
Member

The current graph endpoints are for AAD graph which is different from Microsoft Graph. We can add them, but the existing ones will remain the same.

This was referenced Apr 15, 2022
Closed
Merged
@jhendrixMSFT
Copy link
Member

Fixed in autorest@v0.11.26

mbarnes added a commit to mbarnes/ARO-RP that referenced this issue Apr 26, 2022
@mbarnes
azureclient: Add MicrosoftGraphEndpoint to AROEnvironment
92c580a 
The Azure/go-autorest module does not define an endpoint for the
Microsoft Graph API [1] so define it ourselves for now.

[1] Azure/go-autorest#585
mbarnes added a commit to mbarnes/ARO-RP that referenced this issue May 6, 2022
@mbarnes
azureclient: Add MicrosoftGraphEndpoint to AROEnvironment
4b8c5d6 
The Azure/go-autorest module does not define an endpoint for the
Microsoft Graph API [1] so define it ourselves for now.

[1] Azure/go-autorest#585
mbarnes added a commit to mbarnes/ARO-RP that referenced this issue Jun 7, 2022
@mbarnes
azureclient: Add MicrosoftGraphEndpoint to AROEnvironment
164ed31 
The Azure/go-autorest module does not define an endpoint for the
Microsoft Graph API [1] so define it ourselves for now.

[1] Azure/go-autorest#585
mbarnes added a commit to mbarnes/ARO-RP that referenced this issue Jun 7, 2022
@mbarnes
azureclient: Add MicrosoftGraphEndpoint to AROEnvironment
a0bfc54 
The Azure/go-autorest module does not define an endpoint for the
Microsoft Graph API [1] so define it ourselves for now.

[1] Azure/go-autorest#585
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jhendrixMSFT @miosmian