EdgeHub: Process Subscriptions on device connect event #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varunpuranik
force-pushed
the
varunpuranik/fixSubs1
branch
from
b4a6970 to
ad85c22
Compare
myagley
previously approved these changes
Oct 18, 2018
edge-hub/src/Microsoft.Azure.Devices.Edge.Hub.Core/routing/RoutingEdgeHub.cs
Show resolved
Hide resolved
| try | ||
| { | ||
| Events.ProcessingSubscriptions(identity); | ||
| await this.ProcessSubscriptions(identity.Id); | ||
| IEnumerable<IIdentity> connectedClients = this.connectionManager.GetConnectedClients(); |
There was a problem hiding this comment.
Should we ToList this to get a consistent snapshot? Is it possible for the IEnumerable from the GetConnectedClients to change while iterating?
There was a problem hiding this comment.
Emm, it could.. let me add ToList()
myagley
approved these changes
Oct 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EdgeHub processes subscriptions for connected clients when the device connectivity is restored. Earlier, this was done on the CloudConnectionEstablished callback, which is per cloud connection. With the latest changes, since the CloudConnection is closed when the device loses connectivity, if the client has no active upstream communication but valid subscriptions, those will never be re-processed.
So now we handle this on the DeviceConnected event.
Same logic for refreshing Device scope identities cache as well.