Revert usage of arsing/cross to upstream cross 0.2 #6197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix we needed was merged into upstream a long time ago. Ref: cross-rs/cross#52 Ref: cross-rs/cross@249500e
damonbarry
previously approved these changes
Mar 11, 2022
|
E2E checkin tests failed while building edgelet/iotedge-proxy because they couldn't find openssl devel files. iotedge-proxy is built using cross for x86_64-unknown-linux-musl target in order to make a Docker image for Kubernetes. We don't have a custom image for this target in edgelet/Cross.toml so it uses upstream's image, and upstream stopped including openssl devel package in their images a long time ago. |
These only existed for Kubernetes, but Kubernetes stuff lives in the release/1.1-k8s-preview branch. Dave had removed the .Net parts of Kubernetes support from release/1.1 earlier, so he suggested removing the Rust parts too.
damonbarry
approved these changes
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix we needed was merged into upstream a long time ago.
Ref: cross-rs/cross#52
Ref: cross-rs/cross@249500e
This commit also removes jobs used to build iotedged and iotedge-proxy in
Docker containers, since these were only used for Kubernetes,
but Kubernetes stuff lives in the release/1.1-k8s-preview branch. Dave had
removed the .Net parts of Kubernetes support from release/1.1 earlier,
so he suggested removing the Rust parts too.