Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix image builds #6862

Merged
merged 1 commit into from
Jan 24, 2023
Merged

Fix image builds #6862

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions scripts/linux/buildImage.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,9 +212,18 @@ docker_build_and_tag_and_push() {
build_context=$(gnarly --mod-config $SOURCE_MAP $dockerfile)
fi

# When Docker introduced provenance attestation in buildx 0.10.0 it broke
# our multi-arch image builds. By default, `buildx build` now defaults to
# `--provenance true` which causes even single-architecture images to be
# built as a manifest list (aka multi-arch image). When we use our older
# manifest-tool to create a manifest from three single-arch images (amd64,
# arm32v7, and arm64v8), the tool fails because it can't create a manifest
# list that points to other manifest lists. To mitigate, we'll disable
# provenance attestation for now.
docker buildx build \
--no-cache \
--platform $platform \
--provenance false \
--build-arg 'EXE_DIR=.' \
--file $dockerfile \
--output=$attrs,name=$image,buildinfo-attrs=true \
Expand Down