Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue connecting to Docker daemon with tlsverify enabled #364

Merged
merged 2 commits into from
Dec 7, 2018
Merged

Fix issue connecting to Docker daemon with tlsverify enabled #364

merged 2 commits into from
Dec 7, 2018

Conversation

LazarusX
Copy link
Contributor

@LazarusX LazarusX commented Dec 3, 2018

docker.from_env will simply pick up all the necessary environment variables to connect to a Docker daemon.

@LazarusX LazarusX requested review from adashen and jongio December 3, 2018 02:05
adashen
adashen reviewed Dec 7, 2018
View reviewed changes
Copy link

@adashen adashen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the env DOCKER_HOST will fail?

@LazarusX LazarusX merged commit b9340d7 into master Dec 7, 2018
@LazarusX LazarusX deleted the ray-mac-docker branch December 7, 2018 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adashen adashen adashen approved these changes

@jongio jongio Awaiting requested review from jongio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LazarusX @adashen