Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: rename nodeTemplate to nodeClass #123

Merged
merged 2 commits into from
Jan 29, 2024
Merged

style: rename nodeTemplate to nodeClass #123

merged 2 commits into from
Jan 29, 2024

Conversation

Bryce-Soghigian
Copy link
Collaborator

@Bryce-Soghigian Bryce-Soghigian commented Jan 29, 2024 •
edited
Loading

Fixes #

Description
rename nodeTemplate variable in static parameters to nodeClass
How was this change tested?

  • make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

@coveralls
Copy link

coveralls commented Jan 29, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7700335514

  • 0 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.626%
Totals Coverage Status
Change from base Build 7691997319: 0.0%
Covered Lines: 35605
Relevant Lines: 36471
💛 - Coveralls

@tallaxes
Copy link
Collaborator

@Bryce-Soghigian please fill in minimal PR description. Thanks!

@tallaxes tallaxes added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jan 29, 2024
@Bryce-Soghigian Bryce-Soghigian merged commit 296c836 into main Jan 29, 2024
9 checks passed
@Bryce-Soghigian Bryce-Soghigian deleted the bsoghigian/nodeTemplate branch January 29, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tallaxes tallaxes tallaxes approved these changes

Assignees

@Bryce-Soghigian Bryce-Soghigian

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bryce-Soghigian @coveralls @tallaxes