Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: audit acceptance tests #124

Merged
merged 3 commits into from
Jan 30, 2024
Merged

Conversation

rakechill
Copy link
Contributor

@rakechill rakechill commented Jan 29, 2024

Description
Audited our acceptance testing coverage + structure

  • I updated the test suite for instance types to address a duplicate test + improper syntax.
    • Context + It statements, duplicated Provisioner with KubeletConfig
  • No other changes are needed to our tests since the v1beta1 migration.
  • We've already added previously delayed coverage: spot instances, ephemeral disk, launch template tags.

Dug deeper into launch template provider

  • I've determined that it makes sense to keep launch template provider as is, since it acts as a central place to gather dynamic + static parameters for launching instances + NICs.
  • To clarify for future developers, I'll add an explanation of launch templates in the Development Guide in this repo.

How was this change tested?

  • make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

@rakechill rakechill marked this pull request as ready for review January 29, 2024 19:31
@rakechill rakechill changed the title chore: audit acceptance tests + launch template provider chore: audit acceptance tests Jan 29, 2024
@coveralls
Copy link

coveralls commented Jan 29, 2024

Pull Request Test Coverage Report for Build 7715345261

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.626%

Totals Coverage Status
Change from base Build 7704049977: 0.0%
Covered Lines: 35605
Relevant Lines: 36471

💛 - Coveralls

@tallaxes tallaxes added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/testing Issues or PRs related to testing labels Jan 29, 2024
@rakechill rakechill merged commit 5bff893 into main Jan 30, 2024
9 checks passed
@rakechill rakechill deleted the rakechill/acceptance-tests-update branch January 30, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Issues or PRs related to testing kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants