Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove custom kubebuilder assets location #143

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

tallaxes
Copy link
Collaborator

@tallaxes tallaxes commented Feb 8, 2024

Description

Removes the remaining customization of kubebuilder assets location in devcontainer / Codespace, leftover from #118. This should fix panic on make presumbit on brand new Codespace.

How was this change tested?

make presubmit on new codespace

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note


@tallaxes tallaxes added area/testing Issues or PRs related to testing area/devtools Issues or PRs related to devtools labels Feb 8, 2024
@tallaxes tallaxes self-assigned this Feb 8, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7825996891

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.546%

Totals Coverage Status
Change from base Build 7759811244: 0.0%
Covered Lines: 35741
Relevant Lines: 36640

💛 - Coveralls

@tallaxes tallaxes merged commit 604ac8e into main Feb 8, 2024
9 checks passed
@tallaxes tallaxes deleted the tallaxes/kubebuilder branch February 8, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues or PRs related to devtools area/testing Issues or PRs related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants