Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove ctx from instance provider #153

Merged
merged 2 commits into from
Feb 27, 2024
Merged

chore: remove ctx from instance provider #153

merged 2 commits into from
Feb 27, 2024

Conversation

Bryce-Soghigian
Copy link
Collaborator

@Bryce-Soghigian Bryce-Soghigian commented Feb 16, 2024 •
edited
Loading

Fixes #

Description
Removing useless context parameter in instance provider
How was this change tested?

  • make test
  • make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

@coveralls
Copy link

coveralls commented Feb 16, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8070029775

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.686%
Totals Coverage Status
Change from base Build 8025612097: 0.0%
Covered Lines: 35594
Relevant Lines: 36437
💛 - Coveralls

@Bryce-Soghigian Bryce-Soghigian self-assigned this Feb 21, 2024
@Bryce-Soghigian Bryce-Soghigian marked this pull request as ready for review February 21, 2024 03:10
@Bryce-Soghigian Bryce-Soghigian merged commit 0445060 into main Feb 27, 2024
8 checks passed
@Bryce-Soghigian Bryce-Soghigian deleted the bsoghigian/deparam-removing-ctx-param branch February 27, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tallaxes tallaxes tallaxes approved these changes

Assignees

@Bryce-Soghigian Bryce-Soghigian

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bryce-Soghigian @coveralls @tallaxes