Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removing webhooks from existence for the AKS provider #156

Merged
merged 5 commits into from
Feb 23, 2024

Conversation

Bryce-Soghigian
Copy link
Collaborator

Fixes #

Description
Removing the webhooks from our self hosted provider.

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note


Copy link
Collaborator Author

@Bryce-Soghigian Bryce-Soghigian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test

Copy link
Collaborator Author

@Bryce-Soghigian Bryce-Soghigian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test

@coveralls
Copy link

coveralls commented Feb 20, 2024

Pull Request Test Coverage Report for Build 8013205005

Details

  • 0 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 10 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.06%) to 97.686%

Files with Coverage Reduction New Missed Lines %
pkg/providers/imagefamily/image.go 3 84.0%
pkg/fake/atomic.go 7 67.24%
Totals Coverage Status
Change from base Build 8011567828: 0.06%
Covered Lines: 35595
Relevant Lines: 36438

💛 - Coveralls

@Bryce-Soghigian Bryce-Soghigian self-assigned this Feb 21, 2024
@Bryce-Soghigian Bryce-Soghigian marked this pull request as ready for review February 21, 2024 00:28
comtalyst
comtalyst previously approved these changes Feb 21, 2024
Copy link
Collaborator

@comtalyst comtalyst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@comtalyst comtalyst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

Copy link
Collaborator Author

@Bryce-Soghigian Bryce-Soghigian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test

@Bryce-Soghigian Bryce-Soghigian merged commit d39bc20 into main Feb 23, 2024
16 checks passed
@Bryce-Soghigian Bryce-Soghigian deleted the bsoghigian/removing-webhooks-from-existence branch February 23, 2024 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants