chore(karpenter-core): upgrade karpenter-core to v0.33.0 #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….20231122223643-d0156e68fd30 (1/6) (#139) * bump karpenter-core * correcting test/.../expectations.go * make presubmit * update to Robins suggestion * fix test --------- Co-authored-by: Charlie McBride <Charlie.McBride@microsoft.com>
….20231125072327-0a0b0de0e439 (2/6) (#140) * bump karpenter-core * correcting test/.../expectations.go * make presubmit * go get github.com/aws/karpenter-core@v0.32.2-0.20231125072327-0a0b0de0e439 * make presubmit * update to Robins suggestion * fix test * chore(karpenter-core): go get sigs.k8s.io/karpenter@v0.32.2-0.20231128022149-cd7c3057c6ad (3/6) (#141) * cherry pick import updates * revert go.mod/go.sum * go get sigs.k8s.io/karpenter@v0.32.2-0.20231128022149-cd7c3057c6ad + remove karpenter-core * update KARPENTER_CORE_DIR Makefile * make presubmit + removing unused import * update comment referencing karpenter-core * chore(karpenter-core): go get sigs.k8s.io/karpenter@v0.32.2-0.20231129204947-79dc3457680f (4/6) (#142) * go get sigs.k8s.io/karpenter@v0.32.2-0.20231129204947-79dc3457680f * remove settings usage * make presubmit * move to env vars for make flow * disable webhooks * update Makefile, and skaffold for options over settings * update to working version * remove unused mergeField * remove MergeSettings and complete rest of karpenter-global-settings (and merge logic) are completely removed TODOs * remove settings pkg * enable Drift=true FEATURE_GATES * update unit tests based on comments * chore(karpenter-core): go get sigs.k8s.io/karpenter@v0.32.2-0.20231205044115-1cf3df4ba3cc (5/6) (#149) * go get sigs.k8s.io/karpenter@v0.32.2-0.20231205044115-1cf3df4ba3cc * checkout charliedmcb/bumpKarpenterCore4 .github/ * make presubmit * remove refs to alpha api * revert typo fix as it breaks karpenter-core ref * remove reference of provisioners from webhook * remove crds * undo .github/workflow changes * purge remaining alpha api refs * chore(karpenter-core): go get sigs.k8s.io/karpenter@v0.33.0 (6/6) (#151) * go get sigs.k8s.io/karpenter@v0.33.0 * make presubmit * remove crds for machines and provisioners --------- Co-authored-by: Charlie McBride <Charlie.McBride@microsoft.com> --------- Co-authored-by: Charlie McBride <Charlie.McBride@microsoft.com> --------- Co-authored-by: Charlie McBride <Charlie.McBride@microsoft.com> --------- Co-authored-by: Charlie McBride <Charlie.McBride@microsoft.com> --------- Co-authored-by: Charlie McBride <Charlie.McBride@microsoft.com>
Pull Request Test Coverage Report for Build 8010762990Details
💛 - Coveralls |
This reverts commit 8ceb5eb.
Bryce-Soghigian
approved these changes
Feb 22, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Description
This PR holds all the changes for upgrading us to
v0.33.0ofkarpenter-core. Note: within this change there is a repo rename forkarpenter-coretosigs.k8s.io/karpenter.This PR got reviews for each of the individual sections of the bump within the following staging PRs:
sigs.k8s.io/karpenter.How was this change tested?
make presubmit, and testedmake az-all+ scaling a deployment within a codespace, along with/test*
Does this change impact docs?
Release Note