Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(k-core): version bump to karpenter core v0.34 #164

Merged
merged 5 commits into from
Mar 5, 2024

Conversation

Bryce-Soghigian
Copy link
Collaborator

@Bryce-Soghigian Bryce-Soghigian commented Feb 25, 2024

Fixes #

Description
This pr introduces the newest karpenter crds, and gets us onto the latest version of karpenter core.

How was this change tested?

  • make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

upgrading karpenter core to v0.34

@Bryce-Soghigian Bryce-Soghigian changed the title Bsoghigian/v0.34 clean chore(k-core): version bump to karpenter core v0.34 Feb 25, 2024
chore: change GetNodePods to GetPods

fix: fix
@coveralls
Copy link

coveralls commented Feb 27, 2024

Pull Request Test Coverage Report for Build 8147658012

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.691%

Totals Coverage Status
Change from base Build 8135090136: 0.0%
Covered Lines: 35586
Relevant Lines: 36427

💛 - Coveralls

Copy link
Collaborator

@charliedmcb charliedmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Although, unsure if we want to drop tests for k8s 1.25.x or not.

pkg/apis/v1alpha2/labels.go Show resolved Hide resolved
.github/workflows/ci-test.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@charliedmcb charliedmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test

Copy link
Collaborator

@charliedmcb charliedmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming E2E tests pass, looks good to me

@Bryce-Soghigian Bryce-Soghigian merged commit d019775 into main Mar 5, 2024
18 checks passed
@Bryce-Soghigian Bryce-Soghigian deleted the bsoghigian/v0.34-clean branch March 5, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants