Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(settings): cleanup final settings references #170

Merged
merged 4 commits into from
Mar 7, 2024
Merged

chore(settings): cleanup final settings references #170

merged 4 commits into from
Mar 7, 2024

Conversation

charliedmcb
Copy link
Collaborator

@charliedmcb charliedmcb commented Feb 28, 2024 •
edited
Loading

Fixes #

Description
There were a few lingering settings references I found in the code, and deployment files. Cleaning up and removing those final references.

How was this change tested?
/test & make presubmit

Previously passing E2E run:

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

NONE

charliedmcb
charliedmcb commented Feb 28, 2024
View reviewed changes
Copy link
Collaborator Author

@charliedmcb charliedmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test

@coveralls
Copy link

coveralls commented Feb 28, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8193067882

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.691%
Totals Coverage Status
Change from base Build 8160982922: 0.0%
Covered Lines: 35586
Relevant Lines: 36427
💛 - Coveralls

charliedmcb
charliedmcb commented Feb 28, 2024
View reviewed changes
Copy link
Collaborator Author

@charliedmcb charliedmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test

charliedmcb
charliedmcb commented Feb 28, 2024
View reviewed changes
Copy link
Collaborator Author

@charliedmcb charliedmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test

charliedmcb
charliedmcb commented Feb 28, 2024
View reviewed changes
Copy link
Collaborator Author

@charliedmcb charliedmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test

charliedmcb
charliedmcb commented Mar 4, 2024
View reviewed changes
Copy link
Collaborator Author

@charliedmcb charliedmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test

charliedmcb
charliedmcb commented Mar 7, 2024
View reviewed changes
Copy link
Collaborator Author

@charliedmcb charliedmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test

@charliedmcb charliedmcb merged commit ffc09e4 into main Mar 7, 2024
18 checks passed
@charliedmcb charliedmcb deleted the charliedmcb/cleanupFinalSettingsReferences branch March 7, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bryce-Soghigian Bryce-Soghigian Bryce-Soghigian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@charliedmcb @coveralls @Bryce-Soghigian