Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: core v0.34 bump neglected NewControllers interface change in ccp mode #219

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

comtalyst
Copy link
Collaborator

Fixes #

Description

Recent core version bump has an interface change. The change was addressed in the default mode, but not ccp mode, which currently need to be tested (by building the image) manually.
This PR address that change.

How was this change tested?

  • Manually

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note


@coveralls
Copy link

Pull Request Test Coverage Report for Build 8350881745

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.716%

Totals Coverage Status
Change from base Build 8334587925: 0.0%
Covered Lines: 35591
Relevant Lines: 36423

💛 - Coveralls

@comtalyst comtalyst merged commit 3d30c8a into main Mar 20, 2024
10 checks passed
@comtalyst comtalyst deleted the comtalyst/fix-ccp-0.34-interface branch March 20, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants