Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: managed identity not being enabled for nodes #220

Merged
merged 3 commits into from
Mar 20, 2024
Merged

fix: managed identity not being enabled for nodes #220

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
314be76
fix: managed identity not being enabled for nodes
comtalyst Mar 19, 2024
cf5819c
Merge branch 'main' into comtalyst/fix-managed-identity-not-enabled-f…
comtalyst Mar 19, 2024
ec4d252
Merge branch 'main' into comtalyst/fix-managed-identity-not-enabled-f…
comtalyst Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/providers/imagefamily/bootstrap/aksbootstrap.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ type NodeBootstrapVariables struct {
CloudProviderRatelimitBucket string // s
CloudProviderRatelimitBucketWrite string // s
LoadBalancerDisableOutboundSNAT bool // xd [= false for now]
UseManagedIdentityExtension bool // s [always false?]
UseManagedIdentityExtension bool // s [always true, as long as we only support managed identity]
UseInstanceMetadata bool // s [always true?]
LoadBalancerSKU string // xd [= "Standard" for now]
ExcludeMasterFromStandardLB bool // s [always true?]
Expand Down Expand Up @@ -314,7 +314,7 @@ var (
CloudProviderRatelimitBucket: "100", // s
CloudProviderRatelimitBucketWrite: "100", // s
LoadBalancerDisableOutboundSNAT: false, // xd
UseManagedIdentityExtension: false, // s
UseManagedIdentityExtension: true, // s
UseInstanceMetadata: true, // s
LoadBalancerSKU: "Standard", // xd
ExcludeMasterFromStandardLB: true, // s
Expand Down