Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refresh monitoring tooling for development #232

Merged
merged 8 commits into from
Apr 9, 2024

Conversation

tallaxes
Copy link
Collaborator

@tallaxes tallaxes commented Mar 27, 2024

Description

This refreshes/revives monitoring tooling (Prometheus and Grafana deployment) one can use in development.

It also adds a Cloud Provider Method Duration pane to Karpenter Performance dashboard. (Could be contributed upstream, if it proves useful). Example can be seen here: #230 (comment).

Some changes/updates in monitoring deployment:

  • Deploy to system pool only
  • Disable selected additional Prometheus components
  • Move artifacts to hack/monitoring

How was this change tested?

  • make az-mon-deploy and using Grafana dashboard

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note


@tallaxes tallaxes added area/devtools Issues or PRs related to devtools area/performance Issues or PRs related to performance labels Mar 27, 2024
@tallaxes tallaxes self-assigned this Mar 27, 2024
@tallaxes tallaxes mentioned this pull request Mar 27, 2024
3 tasks
@coveralls
Copy link

coveralls commented Mar 27, 2024

Pull Request Test Coverage Report for Build 8605303768

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 97.755%

Totals Coverage Status
Change from base Build 8577672352: 0.005%
Covered Lines: 35670
Relevant Lines: 36489

💛 - Coveralls

@tallaxes tallaxes merged commit 763f6a5 into main Apr 9, 2024
9 checks passed
@tallaxes tallaxes deleted the tallaxes/monitoring branch April 9, 2024 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues or PRs related to devtools area/performance Issues or PRs related to performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants