Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(logging): GetImageID to use ctx for logging #258

Merged
merged 2 commits into from
Apr 11, 2024
Merged

fix(logging): GetImageID to use ctx for logging #258

merged 2 commits into from
Apr 11, 2024

Conversation

charliedmcb
Copy link
Collaborator

@charliedmcb charliedmcb commented Apr 10, 2024 •
edited
Loading

Fixes #

Description
I noticed this log was creating its own new context, and using that to create a new logger. Updating to use the existing ctx.

How was this change tested?
Nothing additional.
*

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

NONE

charliedmcb
charliedmcb commented Apr 10, 2024
View reviewed changes
Copy link
Collaborator Author

@charliedmcb charliedmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test

@coveralls
Copy link

coveralls commented Apr 10, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8652992545

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 97.761%
Totals Coverage Status
Change from base Build 8642401871: 0.006%
Covered Lines: 35672
Relevant Lines: 36489
💛 - Coveralls

@charliedmcb charliedmcb marked this pull request as ready for review April 11, 2024 20:40
@charliedmcb charliedmcb merged commit 1bf08c1 into main Apr 11, 2024
11 checks passed
@charliedmcb charliedmcb deleted the charliedmcb/fixGetImageIDToUseCtxForLogging branch April 11, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tallaxes tallaxes tallaxes approved these changes

@Bryce-Soghigian Bryce-Soghigian Bryce-Soghigian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@charliedmcb @coveralls @tallaxes @Bryce-Soghigian