Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to sig.k8s.io/karpenter v0.36.0 #260

Merged
merged 4 commits into from
Apr 12, 2024
Merged

Conversation

tallaxes
Copy link
Collaborator

@tallaxes tallaxes commented Apr 11, 2024

Description

Update sig.k8s.io/karpenter dependency to v0.36.0

How was this change tested?

  • make presubmit & E2E tests

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note


Copy link
Collaborator Author

@tallaxes tallaxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test

@coveralls
Copy link

coveralls commented Apr 11, 2024

Pull Request Test Coverage Report for Build 8668774851

Details

  • 9 of 18 (50.0%) changed or added relevant lines in 5 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 97.731%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cloudprovider/cloudprovider.go 1 10 10.0%
Files with Coverage Reduction New Missed Lines %
pkg/cache/unavailableofferings.go 2 95.45%
Totals Coverage Status
Change from base Build 8667733431: -0.02%
Covered Lines: 35660
Relevant Lines: 36488

💛 - Coveralls

@tallaxes
Copy link
Collaborator Author

@tallaxes tallaxes marked this pull request as ready for review April 11, 2024 20:44
@tallaxes tallaxes self-assigned this Apr 11, 2024
@tallaxes tallaxes added the area/dependency Issues or PRs related to dependency changes label Apr 11, 2024
@tallaxes tallaxes added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 11, 2024
Copy link
Collaborator

@charliedmcb charliedmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@Bryce-Soghigian Bryce-Soghigian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to enable spot on spot consolidation by default?

@tallaxes
Copy link
Collaborator Author

Do we want to enable spot on spot consolidation by default?

No, among other things because it requires some tweaks and a lot of testing on cloud provider side (even if not on by default), which is not in place yet. But this is one of the things I plan to take a look at as follow-up to this base dependency update, and some others (e.g. additional CR validation) are of higher priority.

@tallaxes tallaxes merged commit 75453f5 into main Apr 12, 2024
9 of 10 checks passed
@tallaxes tallaxes deleted the tallaxes/core-v0.36.0 branch April 12, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependency Issues or PRs related to dependency changes size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants