-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update to sig.k8s.io/karpenter v0.36.0 #260
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/test
Pull Request Test Coverage Report for Build 8668774851Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to enable spot on spot consolidation by default?
No, among other things because it requires some tweaks and a lot of testing on cloud provider side (even if not on by default), which is not in place yet. But this is one of the things I plan to take a look at as follow-up to this base dependency update, and some others (e.g. additional CR validation) are of higher priority. |
Description
Update
sig.k8s.io/karpenter
dependency to v0.36.0How was this change tested?
make presubmit
& E2E testsDoes this change impact docs?
Release Note