Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dev tools #261

Merged
merged 4 commits into from
Apr 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .devcontainer/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ FROM mcr.microsoft.com/vscode/devcontainers/go:1-${VARIANT}
RUN apt-get update && export DEBIAN_FRONTEND=noninteractive \
&& apt-get -y install --no-install-recommends graphviz

RUN curl -Lo skaffold https://storage.googleapis.com/skaffold/releases/v2.3.1/skaffold-linux-amd64 && \
RUN curl -Lo skaffold https://storage.googleapis.com/skaffold/releases/v2.11.1/skaffold-linux-amd64 && \
install skaffold /usr/local/bin/

# [Optional] Uncomment the next lines to use go get to install anything else you need
Expand Down
18 changes: 7 additions & 11 deletions .golangci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,6 @@ run:
tests: true
allow-parallel-runners: true
timeout: 15m
skip-dirs:
- tools
- hack
- charts
- designs

linters:
enable:
Expand Down Expand Up @@ -38,7 +33,8 @@ linters-settings:
gocyclo:
min-complexity: 11
govet:
check-shadowing: true
enable:
- shadow
revive:
rules:
- name: dot-imports
Expand Down Expand Up @@ -78,8 +74,8 @@ issues:
- linters:
- goheader
source: "^//go:build"

service:
golangci-lint-version: 1.50.x # use the fixed version to not introduce new linters unexpectedly
prepare:
- echo "here I can run custom commands, but no preparation needed for this repo"
exclude-dirs:
- tools
- hack
- charts
- designs
2 changes: 0 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
include Makefile-az.mk

export K8S_VERSION ?= 1.27.x

## Inject the app version into operator.Version
LDFLAGS ?= -ldflags=-X=sigs.k8s.io/karpenter/pkg/operator.Version=$(shell git describe --tags --always | cut -d"v" -f2)

Expand Down
20 changes: 10 additions & 10 deletions hack/toolchain.sh
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/usr/bin/env bash
set -euo pipefail

K8S_VERSION="${K8S_VERSION:="1.27.x"}"
K8S_VERSION="${K8S_VERSION:="1.29.x"}"
KUBEBUILDER_ASSETS="/usr/local/kubebuilder/bin"

main() {
Expand All @@ -11,17 +11,17 @@ main() {

tools() {
go install github.com/google/go-licenses@v1.6.0
go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.55.2
go install github.com/google/ko@v0.15.1
go install github.com/mikefarah/yq/v4@v4.40.5
go install github.com/norwoodj/helm-docs/cmd/helm-docs@v1.12.0
go install sigs.k8s.io/controller-runtime/tools/setup-envtest@v0.0.0-20231031112659-edb7fe9c520e
go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.57.2
go install github.com/google/ko@v0.15.2
go install github.com/mikefarah/yq/v4@v4.43.1
go install github.com/norwoodj/helm-docs/cmd/helm-docs@v1.13.1
go install sigs.k8s.io/controller-runtime/tools/setup-envtest@v0.0.0-20240409134613-20f3f4bed925
go install sigs.k8s.io/controller-tools/cmd/controller-gen@v0.14.0
go install github.com/sigstore/cosign/v2/cmd/cosign@v2.2.3
go install github.com/sigstore/cosign/v2/cmd/cosign@v2.2.4
# go install -tags extended github.com/gohugoio/hugo@v0.110.0
go install golang.org/x/vuln/cmd/govulncheck@v1.0.3
go install github.com/onsi/ginkgo/v2/ginkgo@v2.15.0
go install github.com/rhysd/actionlint/cmd/actionlint@v1.6.26
go install golang.org/x/vuln/cmd/govulncheck@v1.0.4
go install github.com/onsi/ginkgo/v2/ginkgo@latest
Bryce-Soghigian marked this conversation as resolved.
Show resolved Hide resolved
go install github.com/rhysd/actionlint/cmd/actionlint@v1.6.27
go install github.com/mattn/goveralls@v0.0.12
go install github.com/google/go-containerregistry/cmd/crane@v0.19.1

Expand Down