Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: amending release scripts to work for macos #263

Merged
merged 3 commits into from
Apr 13, 2024

Conversation

Bryce-Soghigian
Copy link
Collaborator

Fixes #

Description
This PR adds the required changes to support running these release scripts for macos. The only conflict is the date module as macos date is different from the gnu date format.
How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note


hack/release/common.sh Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Apr 12, 2024

Pull Request Test Coverage Report for Build 8669292044

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.005%) to 97.731%

Files with Coverage Reduction New Missed Lines %
pkg/cache/unavailableofferings.go 2 95.45%
Totals Coverage Status
Change from base Build 8668870284: -0.005%
Covered Lines: 35660
Relevant Lines: 36488

💛 - Coveralls

Co-authored-by: Alex Leites <18728999+tallaxes@users.noreply.github.com>
@tallaxes tallaxes merged commit 0f7e154 into main Apr 13, 2024
9 of 10 checks passed
@tallaxes tallaxes deleted the bsoghigian/amend-release-scripts branch April 13, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants