Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: change helm chart snapshot version #273

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

jacobbaek
Copy link
Contributor

Helm chart version is incorrect.
I changed to correct version.

Fixes #
None

Description
the snapshot helm chart version is not existed.

How was this change tested?

$ export KARPENTER_NAMESPACE=kube-system
export KARPENTER_VERSION=0-f83fadf2c99ffc2b7429cb40a316fcefc0c4752a

helm upgrade --install karpenter oci://ksnap.azurecr.io/karpenter/snapshot/karpenter
--version "${KARPENTER_VERSION}"
--namespace "${KARPENTER_NAMESPACE}" --create-namespace
--values karpenter-values.yaml
--set controller.resources.requests.cpu=1
--set controller.resources.requests.memory=1Gi
--set controller.resources.limits.cpu=1
--set controller.resources.limits.memory=1Gi
--wait
Release "karpenter" does not exist. Installing it now.
Pulled: ksnap.azurecr.io/karpenter/snapshot/karpenter:0-f83fadf2c99ffc2b7429cb40a316fcefc0c4752a
Digest: sha256:a907ef376b6475b296226d6aec07095af2b2eb32483b8c850e1990b04ac3db28
NAME: karpenter
LAST DEPLOYED: Thu Apr 18 09:39:35 2024
NAMESPACE: kube-system
STATUS: deployed
REVISION: 1
TEST SUITE: None

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note


Helm chart version is incorrect.
I changed to correct version.
@tallaxes tallaxes added area/artifacts Issues or PRs related to the hosting of release artifacts area/documentation Issues or PRs related to documentation size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 18, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8730665090

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 97.725%

Files with Coverage Reduction New Missed Lines %
pkg/operator/options/options_validation.go 4 91.84%
Totals Coverage Status
Change from base Build 8696568967: -0.01%
Covered Lines: 35658
Relevant Lines: 36488

💛 - Coveralls

@Bryce-Soghigian Bryce-Soghigian merged commit 47b31bc into Azure:main Apr 18, 2024
10 of 11 checks passed
@jacobbaek jacobbaek deleted the patch-1 branch April 18, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/artifacts Issues or PRs related to the hosting of release artifacts area/documentation Issues or PRs related to documentation size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants