Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: karpenter-values-template #277

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Conversation

uniemimu
Copy link
Contributor

This adds the missing opening brace for the CLUSTER_NAME variable.

Fixes #

Description

How was this change tested?

I was trying to use the helm deployment, it didn't work. So I fixed the troublesome variable.

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • [ x] No

Release Note


This adds the missing opening brace for the CLUSTER_NAME variable.

Signed-off-by: Ukri Niemimuukko <ukri.niemimuukko@intel.com>
Copy link
Collaborator

@tallaxes tallaxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you!

@tallaxes tallaxes added area/devtools Issues or PRs related to devtools size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 18, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8741700292

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.005%) to 97.731%

Files with Coverage Reduction New Missed Lines %
pkg/operator/options/options_validation.go 2 95.92%
Totals Coverage Status
Change from base Build 8734022860: -0.005%
Covered Lines: 35660
Relevant Lines: 36488

💛 - Coveralls

@Bryce-Soghigian Bryce-Soghigian merged commit 1695d8a into Azure:main Apr 18, 2024
10 of 11 checks passed
@uniemimu uniemimu deleted the templatefix branch April 18, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues or PRs related to devtools size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants