Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(release): update calculation of image repo for MCR #281

Merged
merged 2 commits into from
Apr 20, 2024
Merged

chore(release): update calculation of image repo for MCR #281

merged 2 commits into from
Apr 20, 2024

Conversation

charliedmcb
Copy link
Collaborator

Fixes #

Description
Noticed the released helm chart was missing a /controller within its image reference making it fail to pull. Fixing.

How was this change tested?
Nothing additional
*

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

NONE

@charliedmcb charliedmcb marked this pull request as ready for review April 20, 2024 00:05
@coveralls
Copy link

coveralls commented Apr 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8760978121

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.005%) to 97.731%
Files with Coverage Reduction New Missed Lines %
pkg/cache/unavailableofferings.go 2 95.45%
Totals Coverage Status
Change from base Build 8760490820: -0.005%
Covered Lines: 35660
Relevant Lines: 36488
💛 - Coveralls

@charliedmcb charliedmcb merged commit 5729c52 into main Apr 20, 2024
9 of 10 checks passed
@charliedmcb charliedmcb deleted the charliedmcb/updateCalculationOfImageRepoForMCR branch April 20, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tallaxes tallaxes tallaxes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@charliedmcb @coveralls @tallaxes