Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: propagate kubelet identity into node identities #301

Merged
merged 3 commits into from
Apr 28, 2024
Merged

fix: propagate kubelet identity into node identities #301

merged 3 commits into from
Apr 28, 2024

Conversation

tallaxes
Copy link
Collaborator

@tallaxes tallaxes commented Apr 25, 2024 •
edited
Loading

Fixes #300

Description

Updates karpenter-values-template.yaml and configure-values.sh to propagate kubelet identity into node identities

How was this change tested?

  • TBD

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

This was referenced Apr 25, 2024
Closed
Closed
@coveralls
Copy link

coveralls commented Apr 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8870786433

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.774%
Totals Coverage Status
Change from base Build 8870784550: 0.0%
Covered Lines: 36283
Relevant Lines: 37109
💛 - Coveralls

@tallaxes tallaxes marked this pull request as ready for review April 26, 2024 02:00
@tallaxes tallaxes self-assigned this Apr 26, 2024
@tallaxes tallaxes added area/security Issues or PRs related to security area/artifacts Issues or PRs related to the hosting of release artifacts labels Apr 26, 2024
@tallaxes tallaxes requested a review from comtalyst April 26, 2024 02:01
@tallaxes tallaxes added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 26, 2024
@tallaxes tallaxes merged commit fc0b527 into main Apr 28, 2024
9 checks passed
@tallaxes tallaxes deleted the tallaxes/node-identities branch April 28, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@comtalyst comtalyst comtalyst approved these changes

Assignees

@tallaxes tallaxes

Labels
area/artifacts Issues or PRs related to the hosting of release artifacts area/security Issues or PRs related to security size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

node created by karpenter, cannot pull ACR image.
3 participants
@tallaxes @coveralls @comtalyst