Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: nit using lo.FromPtr is safer than directly accessing the pointer #305

Merged
merged 2 commits into from
Apr 28, 2024
Merged

chore: nit using lo.FromPtr is safer than directly accessing the pointer #305

merged 2 commits into from
Apr 28, 2024

Conversation

Bryce-Soghigian
Copy link
Collaborator

@Bryce-Soghigian Bryce-Soghigian commented Apr 28, 2024 •
edited
Loading

Description
Using lo.FromPtr() since its a bit safer

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

@coveralls
Copy link

coveralls commented Apr 28, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8870936363

Details

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.774%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cloudprovider/cloudprovider.go 1 2 50.0%
Totals Coverage Status
Change from base Build 8870831888: 0.0%
Covered Lines: 36283
Relevant Lines: 37109
💛 - Coveralls

@tallaxes tallaxes merged commit aafcbe1 into Azure:main Apr 28, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tallaxes tallaxes tallaxes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bryce-Soghigian @coveralls @tallaxes