Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extending devcontainers to work with github cli ssh access #317

Merged
merged 3 commits into from
Apr 30, 2024

Conversation

Bryce-Soghigian
Copy link
Collaborator

@Bryce-Soghigian Bryce-Soghigian commented Apr 30, 2024

Description
When using the github CLI to access codespaces, you cannot ssh without this plugin.

How was this change tested?
gh codespace ssh -c reimagined-fortnight-
Starting codespace ⢿
Starting codespace ⣾
Linux codespaces-ccffc6 6.2.0-1019-azure #19~22.04.1-Ubuntu SMP Wed Jan 10 22:57:03 UTC 2024 x86_64

The programs included with the Debian GNU/Linux system are free software;
the exact distribution terms for each program are described in the
individual files in /usr/share/doc/*/copyright.

Debian GNU/Linux comes with ABSOLUTELY NO WARRANTY, to the extent
permitted by applicable law.

@Bryce-Soghigian ➜ /workspaces/aks-karpenter (bsoghigian/codespaces) $

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note


@Bryce-Soghigian Bryce-Soghigian marked this pull request as ready for review April 30, 2024 23:15
Co-authored-by: Alex Leites <18728999+tallaxes@users.noreply.github.com>
@tallaxes tallaxes merged commit fd27eba into Azure:main Apr 30, 2024
2 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8902821669

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.774%

Totals Coverage Status
Change from base Build 8870969722: 0.0%
Covered Lines: 36283
Relevant Lines: 37109

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants