-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: supporting 1.30 bootstrap via enabling out of tree credential provider #370
feat: supporting 1.30 bootstrap via enabling out of tree credential provider #370
Conversation
…tainer-registry-config for 1.30 onwards
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/test
Copying feedback on the PR with messy git history There are likely more changes related to the switch to out-of-tree providers (such as setting DisableKubeletCloudCredentialProviders feature gate depending on Kubernetes version), would make sense to package and test this all together |
We discussed offline, seems the feature gate is removed and defaulted correctly in the kubelet binaries so no need for change here.
I need to investigate why and if there is more needed to supporting the out of tree providers work.
I ran the e2e tests here https://github.com/Azure/karpenter-provider-azure/actions/runs/9228266167. Ideally we could run them against 1.30 but as its not out yet no real way to test on 1.30 for apiserver from our e2e tests. Best we can do is set the kubelet version to 1.30. |
Pull Request Test Coverage Report for Build 9324673471Details
💛 - Coveralls |
Pasting this here for reference: https://github.com/Azure/AgentBaker/pull/4258/files @rakechill for Sov cloud support, we will need to pass in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/test
I ran the end to end suite for ACR pull locally. ##[endgroup]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, with minor suggestions
Co-authored-by: Alex Leites <18728999+tallaxes@users.noreply.github.com>
Co-authored-by: Alex Leites <18728999+tallaxes@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/test
…rovider (#370) * feat: supporting 1.30 bootstrap via removing kubelet flag --azure-container-registry-config for 1.30 onwards * feat: adding support for using out of tree credentials in karpenter * test: adding additional validation in our testing for the flags for out of tree provider * fix: adding back in cgroupsv2 from rebase * fix: removing flag from base flags again * fix: fixing tests to properly validate the kubelet flags * fix: ci * fix: adding CSE VAR to contract that was not cherry picked properly from other pr * fix: 1.30 ci * test(unit): fixing client version we get for bootstrap to use the same source of truth * fix: ci lint * Update pkg/providers/imagefamily/bootstrap/aksbootstrap.go Co-authored-by: Alex Leites <18728999+tallaxes@users.noreply.github.com> * chore: adding util for checking if we need to use OOT Credential * chore: moving the OOTCredential CSE var to only be populated for 1.30+ * Update hack/toolchain.sh Co-authored-by: Alex Leites <18728999+tallaxes@users.noreply.github.com> --------- Co-authored-by: Alex Leites <18728999+tallaxes@users.noreply.github.com>
Fixes # NA
Description
Bootstrap for 1.30 will fail if we have the --azure-container-registry-config flag specified.
By removing this flag we get nodes for k8s version 1.30 to bootstrap successfully.
How was this change tested?
Does this change impact docs?
Release Note