Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(release): switch release workflow to have tag trigger #409

Merged
merged 2 commits into from
Jun 18, 2024
Merged

chore(release): switch release workflow to have tag trigger #409

merged 2 commits into from
Jun 18, 2024

Conversation

charliedmcb
Copy link
Collaborator

Fixes #

Description
Working towards a more automated release process. Removing the manual step of triggering with specified tag to automatic trigger based off tagging.

This is aligned behavior with the aws provider:

How was this change tested?
Nothing additional
*

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

NONE

@coveralls
Copy link

coveralls commented Jun 18, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9573392484

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.766%
Totals Coverage Status
Change from base Build 9520296180: 0.0%
Covered Lines: 36286
Relevant Lines: 37115
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 18, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9573398281

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.766%
Totals Coverage Status
Change from base Build 9520296180: 0.0%
Covered Lines: 36286
Relevant Lines: 37115
💛 - Coveralls

Bryce-Soghigian
Bryce-Soghigian approved these changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@Bryce-Soghigian Bryce-Soghigian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but does this mean we should lock down who can actually create tags to be scoped directly to our team? Is it already fairly locked down?

@charliedmcb
Copy link
Collaborator Author

pproved, but does this mean we should lock down who can actually create tags to be scoped directly to our team? Is it already fairly locked down?

We already have restrictions around version tags, but I will do a sanity check over current permissions. Good callout.

@charliedmcb charliedmcb merged commit 6989b1a into main Jun 18, 2024
13 checks passed
@charliedmcb charliedmcb deleted the charliedmcb/switchReleaseWorkflowToHaveTagTrigger branch June 18, 2024 23:44
Bryce-Soghigian pushed a commit that referenced this pull request Sep 12, 2024
@charliedmcb @Bryce-Soghigian
chore(release): switch release workflow to have tag trigger (#409)
71e2bc5 
* switch release workflow to have tag trigger

* removing manual trigger option

---------

Co-authored-by: Charlie McBride <Charlie.McBride@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bryce-Soghigian Bryce-Soghigian Bryce-Soghigian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@charliedmcb @coveralls @Bryce-Soghigian