Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: specify location when creating ACR #414

Merged
merged 4 commits into from
Jun 22, 2024
Merged

fix: specify location when creating ACR #414

merged 4 commits into from
Jun 22, 2024

Conversation

tallaxes
Copy link
Collaborator

@tallaxes tallaxes commented Jun 20, 2024 •
edited
Loading

Description

Explicitly specifying the location for ACR seems to be fixing "ACR not found" issues during E2E. (Would like to follow-up to see why we are trying to create ACR twice ...)

It also switches the default region from eastus (which appears to have some capacity constraints right now) to southcentralus. We don't have GPU quota there, so GPU tests will fail for now.

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

tallaxes
tallaxes commented Jun 20, 2024
View reviewed changes
Copy link
Collaborator Author

@tallaxes tallaxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test

@coveralls
Copy link

coveralls commented Jun 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9590195851

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.766%
Totals Coverage Status
Change from base Build 9587074007: 0.0%
Covered Lines: 36286
Relevant Lines: 37115
💛 - Coveralls

tallaxes
tallaxes commented Jun 20, 2024
View reviewed changes
Copy link
Collaborator Author

@tallaxes tallaxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test

@coveralls
Copy link

coveralls commented Jun 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9590419539

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.766%
Totals Coverage Status
Change from base Build 9587074007: 0.0%
Covered Lines: 36286
Relevant Lines: 37115
💛 - Coveralls

@tallaxes tallaxes marked this pull request as ready for review June 21, 2024 19:59
@coveralls
Copy link

coveralls commented Jun 21, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9619131176

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.764%
Totals Coverage Status
Change from base Build 9603102120: 0.0%
Covered Lines: 36287
Relevant Lines: 37117
💛 - Coveralls

@tallaxes tallaxes added the area/ci Issues or PRs related to ci label Jun 22, 2024
@tallaxes tallaxes self-assigned this Jun 22, 2024
@coveralls
Copy link

coveralls commented Jun 22, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9621866101

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 97.764%
Totals Coverage Status
Change from base Build 9621183275: 0.006%
Covered Lines: 36287
Relevant Lines: 37117
💛 - Coveralls

@tallaxes tallaxes merged commit 5ee206b into main Jun 22, 2024
10 checks passed
@tallaxes tallaxes deleted the tallaxes/ci-acr branch June 22, 2024 01:45
Bryce-Soghigian pushed a commit that referenced this pull request Sep 12, 2024
@tallaxes @Bryce-Soghigian
fix: specify location when creating ACR (#414)
e702779
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bryce-Soghigian Bryce-Soghigian Bryce-Soghigian approved these changes

Assignees

@tallaxes tallaxes

Labels
area/ci Issues or PRs related to ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tallaxes @coveralls @Bryce-Soghigian