test(e2e): cut down on resource name lengths for NRG limit #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tallaxes
reviewed
Nov 28, 2023
Co-authored-by: Alex Leites <18728999+tallaxes@users.noreply.github.com>
tallaxes
approved these changes
Dec 15, 2023
|
This is the E2E run: |
Note: the GPU test is failing, but due to quota issue. Does not seem to be related |
charliedmcb
deleted the
charliedmcb/cutDownResourceNameLengthsForNRGLimit
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Description
When testing in some new regions I noticed we were hitting some extra long NRG names:
https://github.com/Azure/karpenter/actions/runs/6950526005/job/18910870443
Could add something more sophisticated to ensure this is never hit, but I think trimming it down by this much is a quick, and reasonable fix.
How was this change tested?
Nothing additional
*
Does this change impact docs?
Release Note