Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): add new semantic-release workflow #420

Merged
merged 4 commits into from
Jun 28, 2024

Conversation

charliedmcb
Copy link
Collaborator

@charliedmcb charliedmcb commented Jun 27, 2024

Fixes #

Description
We currently have to create the github release, and its release notes manually.

The repo aws is using is no longer maintained:

Because of this there are two approaches I'm looking at for our more automated release process.

I looked over the recommended substitutes and found that I think the action-gh-release might match our current desires the best. Its closest to the old action. However, the semantic-release action could also be useful with some of its additional feature sets, so want to explore that option as well, even though more complex. This PR is exploring the semantic-release option more.

I'm only giving the workflow the following perms, even though its known to now be enough:

  • contents: read
    This is a safeguard from the workflow actually doing a release for now. I'm wanting to complete this since I want to run the workflow to test semantic-release. However, can't run the workflow without it having the file in existence in main. I'm curious if we can maybe leverage it, and if the components are correcting up correctly within the workflow.

How was this change tested?
Sadly there isn't a great way to test this until we have it in main.
*

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

NONE

@coveralls
Copy link

coveralls commented Jun 27, 2024

Pull Request Test Coverage Report for Build 9704146361

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.764%

Totals Coverage Status
Change from base Build 9621914521: 0.0%
Covered Lines: 36287
Relevant Lines: 37117

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 27, 2024

Pull Request Test Coverage Report for Build 9704150319

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.764%

Totals Coverage Status
Change from base Build 9621914521: 0.0%
Covered Lines: 36287
Relevant Lines: 37117

💛 - Coveralls

rakechill
rakechill previously approved these changes Jun 27, 2024
Copy link
Contributor

@rakechill rakechill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me, approving since it should be read-only/for testing

@coveralls
Copy link

coveralls commented Jun 27, 2024

Pull Request Test Coverage Report for Build 9704422160

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.764%

Totals Coverage Status
Change from base Build 9621914521: 0.0%
Covered Lines: 36287
Relevant Lines: 37117

💛 - Coveralls

rakechill
rakechill previously approved these changes Jun 27, 2024
tallaxes
tallaxes previously approved these changes Jun 27, 2024
.github/workflows/release-trigger.yaml Outdated Show resolved Hide resolved
.github/workflows/release-trigger.yaml Show resolved Hide resolved
@charliedmcb charliedmcb dismissed stale reviews from tallaxes and rakechill via d7ae1bb June 28, 2024 17:13
@coveralls
Copy link

coveralls commented Jun 28, 2024

Pull Request Test Coverage Report for Build 9716499578

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.764%

Totals Coverage Status
Change from base Build 9621914521: 0.0%
Covered Lines: 36287
Relevant Lines: 37117

💛 - Coveralls

@charliedmcb charliedmcb merged commit 1de9ce4 into main Jun 28, 2024
16 checks passed
@charliedmcb charliedmcb deleted the charliedmcb/addNewSemanticReleaseWorkflow branch June 28, 2024 20:09
Bryce-Soghigian pushed a commit that referenced this pull request Sep 12, 2024
* add new semantic-release workflow

* remove git secret

* add dryRun

* pin actions/setup-node to sommit

---------

Co-authored-by: Charlie McBride <Charlie.McBride@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants