-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(release): add new semantic-release workflow #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9704146361Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9704150319Details
💛 - Coveralls |
rakechill
previously approved these changes
Jun 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense to me, approving since it should be read-only/for testing
Pull Request Test Coverage Report for Build 9704422160Details
💛 - Coveralls |
rakechill
previously approved these changes
Jun 27, 2024
tallaxes
previously approved these changes
Jun 27, 2024
tallaxes
approved these changes
Jun 28, 2024
Pull Request Test Coverage Report for Build 9716499578Details
💛 - Coveralls |
Bryce-Soghigian
pushed a commit
that referenced
this pull request
Sep 12, 2024
* add new semantic-release workflow * remove git secret * add dryRun * pin actions/setup-node to sommit --------- Co-authored-by: Charlie McBride <Charlie.McBride@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Description
We currently have to create the github release, and its release notes manually.
The repo
aws
is using is no longer maintained:Because of this there are two approaches I'm looking at for our more automated release process.
I looked over the recommended substitutes and found that I think the action-gh-release might match our current desires the best. Its closest to the old action. However, the semantic-release action could also be useful with some of its additional feature sets, so want to explore that option as well, even though more complex. This PR is exploring the semantic-release option more.
I'm only giving the workflow the following perms, even though its known to now be enough:
This is a safeguard from the workflow actually doing a release for now. I'm wanting to complete this since I want to run the workflow to test semantic-release. However, can't run the workflow without it having the file in existence in main. I'm curious if we can maybe leverage it, and if the components are correcting up correctly within the workflow.
How was this change tested?
Sadly there isn't a great way to test this until we have it in main.
*
Does this change impact docs?
Release Note