Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): add production environment to release workflow #435

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

charliedmcb
Copy link
Collaborator

@charliedmcb charliedmcb commented Jul 12, 2024

Fixes #

Description

Using environments for deployment will allow us to put Required reviewers on the release workflows.

Note: this does require us to add a production env to the github repo. I think this approach is correct for us as we are moving towards a more automated release process. However, it does deviate from aws some.

How was this change tested?
Nothing additional
*

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

NONE

@charliedmcb charliedmcb marked this pull request as ready for review July 12, 2024 22:10
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9914701027

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 97.706%

Totals Coverage Status
Change from base Build 9912418452: 0.005%
Covered Lines: 36287
Relevant Lines: 37139

💛 - Coveralls

@tallaxes tallaxes added area/ci Issues or PRs related to ci area/release Issues or PRs related to releasing labels Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Issues or PRs related to ci area/release Issues or PRs related to releasing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants