-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: unit test provisioning in non-zonal regions #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tallaxes
changed the title
test: support unit-testing provisioning in non-zonal regions
test: unit test provisioning in non-zonal regions
Dec 12, 2023
rakechill
previously approved these changes
Dec 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically just had some questions sprawled throughout for my own understanding. One real suggestion is to add a fake.NonZonalRegion
. Overall looks good, so I'll approve
rakechill
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update unit test environment to support testing zonal and non-zonal regions. Capture and use test SKU data from
eastus
andwestcentralus
(non-zonal). Adapt existing zonal tests to run for both zonal and non-zonal environments. Add unit test of provisioning in non-zonal region.Details
Refactor pre-generated SKU data to support multiple regions
Update the SKU generation code for the above
NewDefaultAzureCredential
, docs), onlySUBSCRIPTION_ID
is requiredUpdate codegen (skugen) scripts to generate the above,
eastus
andwestcentralus
(non-zonal)Update unit test environment and test for non-zonal
How was this change tested?
make presubmit
Does this change impact docs?
Release Note