chore(pricing): cleanup pricing duplication #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 12, 2023 03:50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Description
In the pricing provider it was fetching from the pricing API twice (once for spot, and another for on-demand)
Refactored the logic to only fetch once.
Note: the locking feels a little messy as during the price update we grab the lock around the fetch, release it, and then grab it again when updating the prices. However, I don't see this actually causing issues. I think this could still be cleaned up in another PR, but think it'd add a little more refactoring I want to leave out of this one.
How was this change tested?
Nothing additional
*
Does this change impact docs?
Release Note