Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bootstrap contract for GPUs to include GPUImageSHA #76

Merged
merged 4 commits into from
Dec 21, 2023

Conversation

Bryce-Soghigian
Copy link
Collaborator

@Bryce-Soghigian Bryce-Soghigian commented Dec 20, 2023

Description
Agentbaker PR adds an additional field to the bootstrap script that removes the hardcoded value for GPU_IMAGE_SHA, and instead requires the Contract Consumer to supply this value for Ubuntu GPU Bootstrapping.

This Broke bootstrapping for these two image versions, for all the Ubuntu2204containerd Community Images

This PR adds the GPUImageSHA required field to our node bootstrapping variables, which fixes GPU bootstrapping for these two image versions

How was this change tested?

  • make e2etest to run GPU scenario
  • additional code coverage
  • manual scale up

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

fixing GPU bootstrapping for Ubuntu2204containerd

Copy link
Collaborator Author

@Bryce-Soghigian Bryce-Soghigian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test

@Bryce-Soghigian Bryce-Soghigian marked this pull request as ready for review December 20, 2023 10:26
@Bryce-Soghigian Bryce-Soghigian changed the title fix: fixing bootstrap contract for GPUs to include GPUImageSHA fix: bootstrap contract for GPUs to include GPUImageSHA Dec 20, 2023
Copy link
Collaborator

@tallaxes tallaxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test

tallaxes
tallaxes previously approved these changes Dec 20, 2023
Copy link
Collaborator Author

@Bryce-Soghigian Bryce-Soghigian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test

@Bryce-Soghigian Bryce-Soghigian merged commit 8bc64e1 into main Dec 21, 2023
17 of 18 checks passed
@Bryce-Soghigian Bryce-Soghigian deleted the bsoghigian/fix-gpu-bootstrap branch December 21, 2023 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants