New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(identity): add support for using workload id for karpenter pod #84

Merged

charliedmcb merged 34 commits into main from charliedmcb/useWorkloadIdForKarpenter

Jan 30, 2024

Collaborator

charliedmcb commented Jan 5, 2024 •

edited

Loading

Fixes #

Description
Currently the makefile steps, and E2E are running the karpenter pod using the cluster's kubeletIdentity. This is not the identity we want to be using for e2e, or presenting to repo users to be using either. The karpenter pod should have its own workload identity, which this PR adds support for.

Follow ups:

Address logging, and klog
remove SAVM, or support workload id with it
update to using track 2 sdk, rather than the workaround through another lib+track 1

How was this change tested?
Within a codespace so far, but will continue testing before completion.
*

Does this change impact docs?

Yes, PR includes docs updates
Yes, issue opened: #
No

Release Note

Adding support for workload identities which is the patterning that the karpenter pod should be using.

Charlie McBride and others added 5 commits

January 4, 2024 14:21


          add in new make targets for workload id

c7c84d7


          update working code

f04c8c6


          saving possible working version

3a7ae87


          plug in the needed make commands and update acr perms for workload id

455adea


          update to allow sku client to still use SP based off of the workload id

4cd29e0

Bryce-Soghigian reviewed

View reviewed changes

Collaborator

Bryce-Soghigian left a comment

/test

charliedmcb commented

View reviewed changes

Collaborator Author

charliedmcb left a comment

/test

charliedmcb and others added 10 commits

January 8, 2024 21:28


          update to principalId for e2e flow

da40a1c


          adding in more logging

74d0074


          update github actions

33b7d7f


          revert bicep file

847324f


          update TODO comment

a4661f5


          fix github action for now by making two commands

d25eae5


          fix action

119e02c


          Revert "fix action"

63a32e6

This reverts commit 119e02c.


          Revert "fix github action for now by making two commands"

e5a5ea3

This reverts commit d25eae5.


          update sku to use new workload id auth patterning as the backing with…

48bdef2

… wrapper

charliedmcb commented

View reviewed changes

Collaborator Author

charliedmcb left a comment

/test

charliedmcb and others added 2 commits

January 9, 2024 10:50


          Merge branch 'main' into charliedmcb/useWorkloadIdForKarpenter

1bb045c


          support savm path

f89ddc0

charliedmcb commented

View reviewed changes

Collaborator Author

charliedmcb left a comment

/test

charliedmcb and others added 2 commits

January 9, 2024 20:37


          fix bicept format

854ea84


          update so only azureoverlay path is on the new workload id for now

e05e108

charliedmcb commented

View reviewed changes

Collaborator Author

charliedmcb left a comment

/test

charliedmcb marked this pull request as ready for review

January 9, 2024 21:23

charliedmcb commented

View reviewed changes

Collaborator Author

charliedmcb left a comment

/test

charliedmcb commented

View reviewed changes

Collaborator Author

charliedmcb left a comment

/test

charliedmcb commented

View reviewed changes

Collaborator Author

charliedmcb left a comment

/test


          updating multi-line action

d16dbfd

charliedmcb commented

View reviewed changes

Collaborator Author

charliedmcb left a comment

/test

Bryce-Soghigian previously approved these changes

View reviewed changes

Collaborator

Bryce-Soghigian left a comment

Approved given we properly followup with the items that were put aside in this pr

tallaxes assigned charliedmcb

charliedmcb commented

View reviewed changes

Collaborator Author

charliedmcb left a comment

/test


          change to have create MSI happen before create cluster

13b41a3

charliedmcb dismissed Bryce-Soghigian’s stale review via

13b41a3

January 17, 2024 19:51

charliedmcb commented

View reviewed changes

Collaborator Author

charliedmcb left a comment

/test


          Merge branch 'main' into charliedmcb/useWorkloadIdForKarpenter

14eae26

charliedmcb commented

View reviewed changes

Collaborator Author

charliedmcb left a comment

/test

charliedmcb commented

View reviewed changes

Collaborator Author

charliedmcb left a comment

/test

charliedmcb commented

View reviewed changes

Collaborator Author

charliedmcb left a comment

/test


          Merge branch 'main' into charliedmcb/useWorkloadIdForKarpenter

04452c9

charliedmcb commented

View reviewed changes

Collaborator Author

charliedmcb left a comment

/test

charliedmcb commented

View reviewed changes

Collaborator Author

charliedmcb left a comment

/test

Charlie McBride added 2 commits

January 23, 2024 12:46


          update naming to UseCredentialFromEnvironment

77f28fb


          add in old logic for savm

d7a4608

charliedmcb commented

View reviewed changes

Collaborator Author

charliedmcb left a comment

/test

tallaxes approved these changes

View reviewed changes

tallaxes requested a review from comtalyst

January 25, 2024 18:40

comtalyst approved these changes

View reviewed changes


          Merge branch 'main' into charliedmcb/useWorkloadIdForKarpenter

6a36134

charliedmcb commented

View reviewed changes

Collaborator Author

charliedmcb left a comment

/test

coveralls commented Jan 25, 2024 •

edited

Loading

Pull Request Test Coverage Report for Build 7716647603

-16 of 23 (30.43%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.04%) to 97.583%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/auth/cred.go	3	6	50.0%
pkg/auth/config.go	4	9	44.44%
pkg/auth/autorest_auth.go	0	8	0.0%

Totals
Change from base Build 7715671116:	-0.04%
Covered Lines:	35610
Relevant Lines:	36492

💛 - Coveralls


          Merge branch 'main' into charliedmcb/useWorkloadIdForKarpenter

a87eb6b

charliedmcb commented

View reviewed changes

Collaborator Author

charliedmcb left a comment

/test

charliedmcb commented

View reviewed changes

Collaborator Author

charliedmcb left a comment

/test


          Merge branch 'main' into charliedmcb/useWorkloadIdForKarpenter

charliedmcb commented

View reviewed changes

Collaborator Author

charliedmcb left a comment

/test


          Merge branch 'main' into charliedmcb/useWorkloadIdForKarpenter

6b87a35

charliedmcb merged commit 8dd34d2 into main

7 of 8 checks passed

charliedmcb deleted the charliedmcb/useWorkloadIdForKarpenter branch

January 30, 2024 21:31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/e2e-test-framework area/security kind/feature